-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unified flags (SegmentFlags) for ObjectSegment #416
Conversation
… | SEGMENT_RWE_FLAG_EXECUTE) for ObjectSegment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't think about this enough when looking at the issue. I think we should add a SegmentFlags
definition and return that instead. This will be consistent with how we handle other flags (file flags and section flags), and allow us to handle any other flags in addition to rwe.
Thanks for review. I will fix all soon |
Almost all suggestions are fixed. Please review once again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just needs the build fix for Wasm.
emmmm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@philipc Hi, could you publish a new minor version release ? |
Ok, I will soon. FYI, see #418 |
Released 0.28.2 |
To solve #414
Changes: